Horton

Re: Use IsA() macro instead of nodeTag comparison

Kirill Reshke <reshkekirill@gmail.com>

View thread View on postgr.es
From: Kirill Reshke <reshkekirill@gmail.com>
To: Shinya Kato <shinya11.kato@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2026-01-08T13:10:44Z
Lists: pgsql-hackers 
On Thu, 8 Jan 2026 at 17:31, Shinya Kato <shinya11.kato@gmail.com> wrote:
>
> Hi hackers,

Hi

> In copy.c, nodeTag was being compared directly, so I replaced it with
> the IsA() predicate macro for consistency.

Oops. Looks like oversight in 6c8f670. This is indeed case where we
should use IsA()

> I verified that there are no other direct comparisons left by running
> the following command:
> $ git grep "nodeTag(.*) =="

Yep, look like this is the only case in copy.c

> --
> Best regards,
> Shinya Kato
> NTT OSS Center



-- 
Best regards,
Kirill Reshke

Commits

  1. Use IsA() macro in define.c, for sake of consistency.

  2. Use IsA macro, for sake of consistency