Re: Pass ParseState as down to utility functions.

Kirill Reshke <reshkekirill@gmail.com>

From: Kirill Reshke <reshkekirill@gmail.com>

To: Michael Paquier <michael@paquier.xyz>

Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, jian he <jian.universality@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2024-12-10T09:02:56Z

Lists: pgsql-hackers

Attachments

v8-0001-Add-more-regression-tests-to-various-DDL-patterns.patch (application/octet-stream) patch v8-0001
v8-0002-Print-out-error-position-for-number-of-DDL-comman.patch (application/octet-stream) patch v8-0002

On Tue, 10 Dec 2024 at 08:28, Michael Paquier <michael@paquier.xyz> wrote:

> I would suggest to split the patch into two pieces for clarity, based
> on the fact that your v7 patch is doing more than one thing at the
> same time:
> - Introduce new tests for the new coverage (domain, CREATE TABLE OF,
> ALTER TABLE flavors) in a first patch.
> - Introduce the ParseStates in these new code paths in a second patch.
>
> By structuring things this way, it is possible to see what kind of
> difference related to the new ParseStates is introduced, based on the
> new test coverage introduced in the first patch.
>
> This makes also the whole review easier.

Ok. Sure.

> Typo here: s/exists/exist/.

Fixed, Thank you


PFA v8.

-- 
Best regards,
Kirill Reshke

Commits

Print out error position for some ALTER TABLE ALTER COLUMN type
- 65281391a937 18.0 landed
Print out error position for some more DDLs
- 0f23dedc9176 18.0 landed
Print out error position for CREATE DOMAIN
- 39240bcad56d 18.0 landed
Add some regression tests for missing DDL patterns
- 0172b4c9449e 18.0 landed
Re-implement the ereport() macro using __VA_ARGS__.
- e3a87b4991cc 13.0 cited