Horton

Thread

Commits

  1. Fix outdated comment in smgrtruncate()

  2. Cache smgrnblocks() results in recovery.

  1. Fix smgrtruncate code comment.

    Kirill Reshke <reshkekirill@gmail.com> — 2024-07-29T10:50:27Z

    Today I was busy rebasing my Greenplum-related Extendable SMGR
patches on Cloudberry, and I faced some conflicts.
While resolving them I noticed code & comments inconsistency in smgr.c
in smgrtruncate function, which tracks down to
c5315f4f44843c20ada876fdb0d0828795dfbdf5. In this commit,
smgr_fsm_nblocks & smgr_vm_nblocks fields were removed, however
comments were not fixed accordingly.

So i suggest to fix this, PFA

  2. Re: Fix smgrtruncate code comment.

    Heikki Linnakangas <hlinnaka@iki.fi> — 2024-07-29T11:27:03Z

    On 29/07/2024 13:50, Kirill Reshke wrote:
> Today I was busy rebasing my Greenplum-related Extendable SMGR
> patches on Cloudberry, and I faced some conflicts.
> While resolving them I noticed code & comments inconsistency in smgr.c
> in smgrtruncate function, which tracks down to
> c5315f4f44843c20ada876fdb0d0828795dfbdf5. In this commit,
> smgr_fsm_nblocks & smgr_vm_nblocks fields were removed, however
> comments were not fixed accordingly.
> 
> So i suggest to fix this, PFA

Applied, thanks!

-- 
Heikki Linnakangas
Neon (https://neon.tech)