Horton

Thread

Commits

  1. test_ddl_deparse: Rename test create_sequence_1 to create_sequence

  1. test_ddl_deparse: Rename test create_sequence_1

    Michael Paquier <michael@paquier.xyz> — 2025-08-18T07:40:27Z

    Hi all,

While looking at this area of the code, I got confused by the choice
of using create_sequence_1 as name for one of the scripts in the test
module test_ddl_deparse.  This is usually reserved for alternate
outputs, but we don't need to rely on that in this case.

How about renaming the test as per the attached?
Thanks,
--
Michael

  2. Re: test_ddl_deparse: Rename test create_sequence_1

    Kirill Reshke <reshkekirill@gmail.com> — 2025-08-18T09:05:20Z

    Hi!

On Mon, 18 Aug 2025 at 12:40, Michael Paquier <michael@paquier.xyz> wrote:
>
> Hi all,
>
> While looking at this area of the code, I got confused by the choice
> of using create_sequence_1 as name for one of the scripts in the test
> module test_ddl_deparse.  This is usually reserved for alternate
> outputs, but we don't need to rely on that in this case.

I did not find any related discussion or objections in the thread [0],
so this is probably an oversight of b488c58.

Also, do we have any doc about regression file names/alternate
outputs? I did not find any.


[0] https://www.postgresql.org/message-id/20150508192921.GM2523%40alvh.no-ip.org

-- 
Best regards,
Kirill Reshke

  3. Re: test_ddl_deparse: Rename test create_sequence_1

    Michael Paquier <michael@paquier.xyz> — 2025-08-18T09:15:22Z

    On Mon, Aug 18, 2025 at 02:05:20PM +0500, Kirill Reshke wrote:
> Also, do we have any doc about regression file names/alternate
> outputs? I did not find any.

You have missed this one:
https://www.postgresql.org/docs/devel/regress-variant.html
--
Michael