Re: Sequence Access Methods, round two

Kirill Reshke <reshkekirill@gmail.com>

From: Kirill Reshke <reshkekirill@gmail.com>

To: Michael Paquier <michael@paquier.xyz>

Cc: Peter Eisentraut <peter@eisentraut.org>, Peter Smith <smithpb2250@gmail.com>, Postgres hackers <pgsql-hackers@lists.postgresql.org>

Date: 2025-08-18T13:15:05Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Refactor init_params() in sequence.c to not use FormData_pg_sequence_data
- ba3d93b2e806 19 (unreleased) landed
Fix comment thinko in sequence.c
- 17a3f79f812c 17.0 landed
Group more closely cache updates for backends in sequence.c
- 6e951bf98e2e 17.0 landed
Introduce sequence_*() access functions
- 449e798c77ed 17.0 landed

On Mon, 18 Aug 2025 at 09:49, Michael Paquier <michael@paquier.xyz> wrote:
>

> We could just
> reuse AlterColumn, saving from the extra sub-command.  What do you
> think?

Yes, this resonates with me better.

> Rebased the rest as attached, for now.

I have a small enhancement to the patch set.
In v17-0003:
```
reshke@yezzey-cbdb-bench:~/cpg$ git diff
diff --git a/src/bin/psql/tab-complete.in.c b/src/bin/psql/tab-complete.in.c
index 8ac13b26fe6..84b7f55fd73 100644
--- a/src/bin/psql/tab-complete.in.c
+++ b/src/bin/psql/tab-complete.in.c
@@ -3365,7 +3365,7 @@ match_previous_words(int pattern_id,
                COMPLETE_WITH("TYPE");
        /* Complete "CREATE ACCESS METHOD <name> TYPE" */
        else if (Matches("CREATE", "ACCESS", "METHOD", MatchAny, "TYPE"))
-               COMPLETE_WITH("INDEX", "TABLE");
+               COMPLETE_WITH("INDEX", "TABLE", "SEQUENCE");
        /* Complete "CREATE ACCESS METHOD <name> TYPE <type>" */
        else if (Matches("CREATE", "ACCESS", "METHOD", MatchAny,
"TYPE", MatchAny))
                COMPLETE_WITH("HANDLER");
```


-- 
Best regards,
Kirill Reshke