Horton

Re: ALTER DATABASE RESET with unexistent guc doesn't report an error

Kirill Reshke <reshkekirill@gmail.com>

View thread
From: Kirill Reshke <reshkekirill@gmail.com>
To: Vitaly Davydov <v.davydov@postgrespro.ru>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2025-09-11T12:07:29Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Reject "ALTER DATABASE/USER ... RESET foo" with invalid GUC name.

Hi!

On Thu, 11 Sept 2025 at 13:35, Vitaly Davydov <v.davydov@postgrespro.ru> wrote:
> I've also think that ALTER DATABASE RESET TABLESPACE does
> nothing without any error reporting.

I can see that ALTER DATABASE RESET TABLESPACE indeed does not change
dattablespace.
Documentation also lacks any information about support of something
like this. [0]

This test case looks like just an oversight of 0844b3968985
I think we can remove "support" for ALTER DATABASE RESET TABLESPACE.

LGTM


[0] https://www.postgresql.org/docs/current/sql-alterdatabase.html


-- 
Best regards,
Kirill Reshke