Re: duplicate function declaration in multirangetypes_selfuncs.c
Pavel Borisov <pashkin.elfe@gmail.com>
From: Pavel Borisov <pashkin.elfe@gmail.com>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Anton Voloshin <a.voloshin@postgrespro.ru>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>,
Alexander Korotkov <aekorotkov@gmail.com>
Date: 2023-04-21T11:21:24Z
Lists: pgsql-hackers
Attachments
- v2-0002-Remove-duplicate-break-in-find_struct_member-s-sw.patch (application/octet-stream) patch v2-0002
- v2-0001-Remove-double-declaration-of-default_multirange_s.patch (application/octet-stream) patch v2-0001
Hi! On Fri, 21 Apr 2023 at 15:14, Daniel Gustafsson <daniel@yesql.se> wrote: > > > On 21 Apr 2023, at 12:58, Anton Voloshin <a.voloshin@postgrespro.ru> wrote: > > > > On 21/04/2023 13:45, Pavel Borisov wrote: > >> The patch is attached. Anyone to commit? > > > > Speaking of duplicates, I just found another one: > > > break; > > > break; > > in src/interfaces/ecpg/preproc/variable.c > > (in all stable branches). > > Indeed, coming in via 086cf1458 it's over a decade old. > > > Additional patch attached. Or both could go in the same commit, it's up to committer. > > I'll take care of these in a bit (unless someone finds more, or objects) > backpatching them to their respective origins branches. > > -- > Daniel Gustafsson Technically patches 0001 and 0002 in the thread above don't form patchset i.e. 0002 will not apply over 0001. Fixed this in v2. (They could be merged into one but as they fix completely unrelated things, I think a better way to commit them separately.) Pavel.
Commits
-
Remove duplicate lines of code
- a63b821c1375 15.3 landed
- 69537f5d17ea 16.0 landed
- 50b23e437477 13.11 landed
- 34e09e71aca5 14.8 landed
- 082e571c6503 12.15 landed
- 082b59335dbb 11.20 landed