Horton

Re: OOM in spgist insert

Pavel Borisov <pashkin.elfe@gmail.com>

View thread View on postgr.es
From: Pavel Borisov <pashkin.elfe@gmail.com>
To: Dilip Kumar <dilipbalaut@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Alvaro Herrera <alvherre@alvh.no-ip.org>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-05-14T08:21:28Z
Lists: pgsql-hackers 
Now when checking for shortening of  leaf tuple is added LongValuesOK
become slightly redundant. I'd propose to replace it with more legible name
as LongValuesOK doesn't mean they are warranted to be ok just that we can
try to shorten them? What about tryShortening, trySuffixing or
can(Try)ShortenTuple?


-- 
Best regards,
Pavel Borisov

Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>

Commits

  1. Prevent infinite insertion loops in spgdoinsert().

  2. Fix query-cancel handling in spgdoinsert().

  3. Refactor CHECK_FOR_INTERRUPTS() to add flexibility.