Horton

Re: BUG #17212: pg_amcheck fails on checking temporary relations

Pavel Borisov <pashkin.elfe@gmail.com>

View thread View on postgr.es
From: Pavel Borisov <pashkin.elfe@gmail.com>
To: Peter Geoghegan <pg@bowt.ie>
Cc: Alexander Lakhin <exclusion@gmail.com>, Mark Dilger <mark.dilger@enterprisedb.com>, Robert Haas <robertmhaas@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2021-10-06T15:14:21Z
Lists: pgsql-bugs, pgsql-hackers 
Hi, hackers!

We've looked through the initial patch and the exclusion of temporary
tables from pg_amcheck seems the right thing. Also it is not the matter
anyone disagrees here, and we propose to commit it alone.
Supplementary things/features might be left for further discussion but
refusing to check temporary tables is the only option IMO.

The patch applies cleanly, tests succeed. I'd propose to set it as RFC.
--
Best regards,
Pavel Borisov, Maxim Orlov

Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>

Commits

  1. Remove unstable pg_amcheck tests.

  2. pg_amcheck: avoid unhelpful verification attempts.

  3. amcheck: Skip unlogged relations in Hot Standby.

  4. amcheck: Skip unlogged relations during recovery.