Re: [PATCH] Covering SPGiST index
Pavel Borisov <pashkin.elfe@gmail.com>
From: Pavel Borisov <pashkin.elfe@gmail.com>
To: "Andrey M. Borodin" <x4mmm@yandex-team.ru>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2020-08-10T07:34:24Z
Lists: pgsql-hackers
Attachments
- spgist-covering-0002.diff (application/octet-stream) patch
> > On a first glance the whole concept of non-multicolumn index with included > attributes seems...well, just difficult to understand. > But I expect for SP-GiST this must be single key with multiple included > attributes, right? > I couldn't find a test that checks impossibility of on 2-column SP-GiST, > only few asserts about it. Is this checked somewhere else? > Yes, SpGist is by its construction a single-column index, there is no such thing like 2-column SP-GiST yet. In the same way like original SpGist will refuse to add a second key column, this remains after modification as well, with exception of columns attached by INCLUDE directive. They can be (INDEX_MAX_KEYS -1) pieces and they will not be used to create additional index trees (as there is only one), they will be just attached to the key tree leafs tuple. I also little bit corrected error reporting for the case when user wants to invoke index build with not one column. Thanks! -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>
Commits
-
Support INCLUDE'd columns in SP-GiST.
- 09c1c6ab4bc5 14.0 landed
-
Rethink handling of pass-by-value leaf datums in SP-GiST.
- 1ebdec8c0329 14.0 landed