Horton

Re: Unit tests for SLRU

Pavel Borisov <pashkin.elfe@gmail.com>

View thread View on postgr.es
From: Pavel Borisov <pashkin.elfe@gmail.com>
To: Aleksander Alekseev <aleksander@timescale.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Michael Paquier <michael@paquier.xyz>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>, Maxim Orlov <orlovmg@gmail.com>, Noah Misch <noah@leadboat.com>, Daniel Gustafsson <daniel@yesql.se>
Date: 2022-11-15T10:43:06Z
Lists: pgsql-hackers 
Hi, Alexander!
> > I have reworked that as per the attached, that provides basically the
> > same coverage, going through a SQL interface for the whole thing.
> > Like all the other tests of its kind, this does not use a TAP test,
> > relying on a custom configuration file instead.  This still needs some
> > polishing, but the basics are here.
>
> Many thanks for the updated patch. I didn't know one can run tests
> with a custom postgresql.conf without using TAP tests.
>
> > What do you think?
>
> It looks much better than before. I replaced strcpy() with strncpy()
> and pgindent'ed the code. Other than that to me it looks ready to be
> committed.
I've looked through the patch again. I agree it looks better and can
be committed.
Mark it as RfC now.

Regards,
Pavel Borisov

Commits

  1. Add test module for SLRUs

  2. Fix comment of SimpleLruInit() in slru.c