Horton

Re: Partition Check not updated when insert into a partition

Pavel Borisov <pashkin.elfe@gmail.com>

View thread View on postgr.es
From: Pavel Borisov <pashkin.elfe@gmail.com>
To: Nitin Jadhav <nitinjadhavpostgres@gmail.com>
Cc: Amit Langote <amitlangote09@gmail.com>, "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-10-06T13:40:37Z
Lists: pgsql-hackers

Attachments

Hi, hackers!

We've reviewed patch v3 and found it right. Completely agree that in case
we attach/detach partition relcaches for all child relations (if they
exist) need invalidation.
Installcheck world succeeds after the patch. Tests from the patch fail as
they should when run on the master branch. Found no problems.

Overall patch is good and I'd recommend it to be committed.

We've made v4 patch according to Nitin's advice and tested it, but still
have no objections to patch v3. Each can be committed, equally good.

Big thanks to you, Álvaro and Amit for working on this!

-- 
Best regards,
Pavel Borisov, Maxim Orlov

Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>

Commits

  1. Invalidate partitions of table being attached/detached