Fortify float4 and float8 regression tests by ordering test results

Pavel Borisov <pashkin.elfe@gmail.com>

From: Pavel Borisov <pashkin.elfe@gmail.com>

To: Postgres hackers <pgsql-hackers@lists.postgresql.org>

Date: 2025-04-22T13:31:57Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Avoid depending on post-UPDATE row order in float4/float8 tests.
- da83b1ea10c2 18.0 landed

Attachments

v1-0001-Fortify-float4-and-float8-tests-by-ordering-test-.patch (application/octet-stream) patch v1-0001

Hi, hackers!

I noticed that SELECT results in float4 and float8 tests lack ORDER BY
clauses. This makes test results depend on the current heap/MVCC
implementation.

If I try to run the float8 test on a table created with a different
access method provided by an extension, I'm getting results ordered
differently.

It's not a big problem, but propose a simple fix for the tests. It
just adds ORDER BY 1 to all relevant float4 and floa8 queries. I don't
have a strong opinion about backpatching this, but as the patch
changes only regression tests, it's maybe also worth backpatching.

Regards,
Pavel Borisov,
Supabase.