Re: Possible pointer var TupleDesc rettupdesc used not initialized (src/backend/optimizer/util/clauses.c)

Zhihong Yu <zyu@yugabyte.com>

From: Zhihong Yu <zyu@yugabyte.com>
To: Ranier Vilela <ranier.vf@gmail.com>
Cc: Mark Dilger <mark.dilger@enterprisedb.com>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2021-05-25T02:39:17Z
Lists: pgsql-hackers
On Mon, May 24, 2021 at 7:21 PM Ranier Vilela <ranier.vf@gmail.com> wrote:

> Em seg., 24 de mai. de 2021 às 22:42, Mark Dilger <
> mark.dilger@enterprisedb.com> escreveu:
>
>>
>>
>> > On May 24, 2021, at 5:37 PM, Ranier Vilela <ranier.vf@gmail.com> wrote:
>> >
>> > Hi,
>> >
>> > Possible pointer TupleDesc rettupdesc used not initialized?
>> >
>> > if (!isNull) at line 4346 taking a true branch, the function
>> check_sql_fn_retval at line 4448 can use rettupdesc uninitialized.
>>
>> Care to submit a patch?
>>
> Hi Mark, sorry but not.
> I examined the code and I can't say what the correct value is for
> rettupdesc.
>

Hi,
It seems the following call would fill up value for rettupdesc :

functypclass = get_expr_result_type((Node *) fexpr, NULL, &rettupdesc);

Cheers

>
> regards,
> Ranier Vilela
>
>
> <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail> Livre
> de vírus. www.avast.com
> <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail>.
> <#m_-660087238671669467_DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
>

Commits

  1. Fix use of uninitialized variable in inline_function().