Re: cataloguing NOT NULL constraints

Zhihong Yu <zyu@yugabyte.com>

From: Zhihong Yu <zyu@yugabyte.com>

To: Alvaro Herrera <alvherre@alvh.no-ip.org>

Cc: Amit Langote <amitlangote09@gmail.com>, Laurenz Albe <laurenz.albe@cybertec.at>, Pg Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2022-09-10T00:28:19Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Revert structural changes to not-null constraints
- 6f8bb7c1e961 17.0 landed
Fix inconsistencies in error messages
- 21ac38f498b3 17.0 landed
Disallow direct change of NO INHERIT of not-null constraints
- d45597f72fe5 17.0 landed
Disallow NO INHERIT not-null constraints on partitioned tables
- 13daa33fa5a6 17.0 landed
Better handle indirect constraint drops
- 0cd711271d42 17.0 cited
Don't try to assign smart names to constraints
- d72d32f52d26 17.0 cited
Fix restore of not-null constraints with inheritance
- d9f686a72ee9 17.0 landed
ATTACH PARTITION: Don't match a PK with a UNIQUE constraint
- cee8db3f680b 17.0 landed
Fix propagating attnotnull in multiple inheritance
- c3709100be73 17.0 landed
Check stack depth in new recursive functions
- b0f7dd915bca 17.0 landed
Move privilege check to the right place
- ac22a9545ca9 17.0 cited
Update information_schema definition for not-null constraints
- 3af721794272 17.0 landed
Fix not-null constraint test
- d0ec2ddbe088 17.0 landed
Disallow changing NO INHERIT status of a not-null constraint
- 9b581c534186 17.0 cited
Catalog not-null constraints
- b0e96f311985 17.0 cited
parallel_schedule: add comment on event_trigger test dependency
- c8e43c22be27 17.0 landed
Revert "Catalog NOT NULL constraints" and fallout
- 9ce04b50e120 16.0 landed
Adjust contrib/sepgsql regression test expected outputs.
- 76c111a7f166 16.0 landed
Fix table name clash in recently introduced test
- 728015a47016 16.0 landed
Catalog NOT NULL constraints
- e056c557aef4 16.0 landed
Change the rules for inherited CHECK constraints to be essentially the same
- cd902b331dc4 8.4.0 cited

Hi,
w.r.t. the while loop in findNotNullConstraintAttnum():

+       if (multiple == NULL)
+           break;

I think `pfree(arr)` should be called before breaking.

+       if (constraint->cooked_expr != NULL)
+           return
tryExtractNotNullFromNode(stringToNode(constraint->cooked_expr), rel);
+       else
+           return tryExtractNotNullFromNode(constraint->raw_expr, rel);

nit: the `else` keyword is not needed.

+   if (isnull)
+       elog(ERROR, "null conbin for constraint %u", conForm->oid);

It would be better to expand `conbin` so that the user can better
understand the error.

Cheers

>