Horton

Re: ExecRTCheckPerms() and many prunable partitions

Zhihong Yu <zyu@yugabyte.com>

View thread View on postgr.es
From: Zhihong Yu <zyu@yugabyte.com>
To: Amit Langote <amitlangote09@gmail.com>
Cc: Julien Rouhaud <rjuju123@gmail.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Tom Lane <tgl@sss.pgh.pa.us>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-01-17T15:45:06Z
Lists: pgsql-hackers 
On Mon, Jan 17, 2022 at 3:51 AM Amit Langote <amitlangote09@gmail.com>
wrote:

> On Thu, Jan 13, 2022 at 3:39 PM Amit Langote <amitlangote09@gmail.com>
> wrote:
> > On Thu, Jan 13, 2022 at 12:10 PM Julien Rouhaud <rjuju123@gmail.com>
> wrote:
> > > On Mon, Dec 20, 2021 at 04:13:04PM +0900, Amit Langote wrote:
> > > > Patch 0002 needed a rebase, because a conflicting change to
> > > > expected/rules.out has since been committed.
> > >
> > > The cfbot reports new conflicts since about a week ago with this patch:
> > > Could you send a rebased patch?  In the meantime I'll switch the cf
> entry to
> > > Waiting on Author.
> >
> > Turns out I had never compiled this patch set to exercise xml and lz4
> > tests, whose output files contained view definitions shown using \d
> > that also needed to be updated in the 0002 patch.
> >
> > Fixed in the attached updated version.
>
> cfbot tells me it found a conflict when applying v7 on the latest
> HEAD.  Fixed in the attached v8.
>
> Hi,
For patch 02, in the description:

present for locking views during execition

Typo: execution.

+    * to be used by the executor to lock the view relation and for the
+    * planner to be able to record the view relation OID in the PlannedStmt
+    * that it produces for the query.

I think the sentence about executor can be placed after the sentence for
the planner.

For patch 01, GetRelPermissionInfo():

+       return perminfo;
+   }
+   else

keyword 'else' is not needed - the else block can be left-indented.

Cheers

Commits

  1. Add a test case for a316a3bc

  2. Correctly set userid of subquery relations' child rels

  3. Fix buggy recursion in flatten_rtes_walker().

  4. Remove some dead code in selfuncs.c

  5. Update outdated comment in ApplyRetrieveRule

  6. Rework query relation permission checking

  7. Generalize ri_RootToPartitionMap to use for non-partition children

  8. Stop accessing checkAsUser via RTE in some cases

  9. Add 'missing_ok' argument to build_attrmap_by_name