Re: DEALLOCATE IF EXISTS

Vik Reykja <vikreykja@gmail.com>

From: Vik Reykja <vikreykja@gmail.com>

To: Tom Lane <tgl@sss.pgh.pa.us>

Cc: Sébastien Lardière <slardiere@hi-media.com>, Simon Riggs <simon@2ndquadrant.com>, pgsql-hackers@postgresql.org, cedric@2ndquadrant.fr

Date: 2012-10-09T14:44:07Z

Lists: pgsql-hackers

Attachments

deallocate_if_exists.2.patch (application/octet-stream) patch

On Tue, Oct 9, 2012 at 4:09 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:

> =?ISO-8859-1?Q?S=E9bastien_Lardi=E8re?= <slardiere@hi-media.com> writes:
> > Indeed, brackets was not correct, it's better now (I think), and correct
> > some comments.
>
> Still wrong ... at the very least you missed copyfuncs/equalfuncs.
> In general, when adding a field to a struct, it's good practice to
> grep for all uses of that struct.
>

I don't see Sébastien's message, but I made the same mistake in my patch.
Another one is attached with copyfuncs and equalfuncs.  I did a grep for
DeallocateStmt and I don't believe I have missed anything else.

Also, I'm changing the subject so as not to hijack this thread any further.