Horton

Re: odd buildfarm failure - "pg_ctl: control file appears to be corrupt"

vignesh C <vignesh21@gmail.com>

View thread View on postgr.es
From: vignesh C <vignesh21@gmail.com>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: David Steele <david@pgmasters.net>, Michael Paquier <michael@paquier.xyz>, Stephen Frost <sfrost@snowman.net>, Daniel Gustafsson <daniel@yesql.se>, "Anton A. Melnikov" <aamelnikov@inbox.ru>, Tom Lane <tgl@sss.pgh.pa.us>, Andres Freund <andres@anarazel.de>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2024-02-01T18:19:39Z
Lists: pgsql-hackers 
On Thu, 11 Jan 2024 at 19:50, vignesh C <vignesh21@gmail.com> wrote:
>
> On Tue, 17 Oct 2023 at 04:18, Thomas Munro <thomas.munro@gmail.com> wrote:
> >
> > I pushed the retry-loop-in-frontend-executables patch and the
> > missing-locking-in-SQL-functions patch yesterday.  That leaves the
> > backup ones, which I've rebased and attached, no change.  It sounds
> > like we need some more healthy debate about that backup label idea
> > that would mean we don't need these (two birds with one stone), so
> > I'll just leave these here to keep the cfbot happy in the meantime.
>
> I have changed the status of this to "Waiting on Author" as Robert's
> comments have not yet been handled. Feel free to post an updated
> version and change the status accordingly.

The patch which you submitted has been awaiting your attention for
quite some time now.  As such, we have moved it to "Returned with
Feedback" and removed it from the reviewing queue. Depending on
timing, this may be reversible.  Kindly address the feedback you have
received, and resubmit the patch to the next CommitFest.

Regards,
Vignesh

Commits

  1. Try to handle torn reads of pg_control in frontend.

  2. Acquire ControlFileLock in relevant SQL functions.