Re: Logical Replication of sequences

vignesh C <vignesh21@gmail.com>

From: vignesh C <vignesh21@gmail.com>

To: Peter Smith <smithpb2250@gmail.com>

Cc: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, Masahiko Sawada <sawada.mshk@gmail.com>, shveta malik <shveta.malik@gmail.com>, Shlok Kyal <shlok.kyal.oss@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>, Peter Eisentraut <peter@eisentraut.org>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Euler Taveira <euler@eulerto.com>, Michael Paquier <michael@paquier.xyz>, "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>, "Jonathan S. Katz" <jkatz@postgresql.org>

Date: 2025-05-01T03:16:27Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Doc: Add documentation for sequence synchronization.
- 55cefadde874 19 (unreleased) landed
Remove unused assignment in CREATE PUBLICATION grammar.
- bfb7419b0bbe 19 (unreleased) landed
Add seq_sync_error_count to subscription statistics.
- f6a4c498dcf6 19 (unreleased) landed
Fix few issues in commit 5509055d69.
- 5a4eba558aa7 19 (unreleased) landed
Add sequence synchronization for logical replication.
- 5509055d6956 19 (unreleased) landed
Add worker type argument to logical replication worker functions.
- 3e8e05596a02 19 (unreleased) landed
Introduce "REFRESH SEQUENCES" for subscriptions.
- f0b3573c3aac 19 (unreleased) landed
Refactor logical worker synchronization code into a separate file.
- 41c674d2e31e 19 (unreleased) landed
Standardize use of REFRESH PUBLICATION in code and messages.
- 2436b8c047ff 19 (unreleased) landed
Add "ALL SEQUENCES" support to publications.
- 96b378497346 19 (unreleased) landed
Expose sequence page LSN via pg_get_sequence_data.
- b93172ca59f4 19 (unreleased) landed
Resume conflict-relevant data retention automatically.
- 0d48d393d465 19 (unreleased) cited
Post-commit review fixes for 228c370868.
- 1f7e9ba3ac4e 19 (unreleased) cited
Generate GUC tables from .dat file
- 63599896545c 19 (unreleased) cited

Attachments

v20250501-0001-Introduce-pg_sequence_state-function-for-e.patch (text/x-patch) patch v20250501-0001
v20250501-0005-Documentation-for-sequence-synchronization.patch (text/x-patch) patch v20250501-0005
v20250501-0003-Reorganize-tablesync-Code-and-Introduce-sy.patch (text/x-patch) patch v20250501-0003
v20250501-0004-Enhance-sequence-synchronization-during-su.patch (text/x-patch) patch v20250501-0004
v20250501-0002-Introduce-ALL-SEQUENCES-support-for-Postgr.patch (text/x-patch) patch v20250501-0002

On Tue, 29 Apr 2025 at 06:15, Peter Smith <smithpb2250@gmail.com> wrote:
>
> Hi Vignesh.
>
> Some trivial review comments for DOCS patch v20250428-0005.
>
> ======
> doc/src/sgml/logical-replication.sgml
>
> 1.
> +   Publications may currently only contain tables or sequences. Objects must be
> +   added explicitly, except when a publication is created using
> +   <literal>FOR TABLES IN SCHEMA</literal>, or <literal>FOR ALL
> TABLES</literal>,
> +   or <literal>FOR ALL SEQUENCES</literal>. Unlike tables, the current state of
> +   sequences may be synchronised at any time. For more information, refer to
> +   <xref linkend="logical-replication-sequences"/>.
>    </para>
>
> AFAIK the PostgreSQL documentation uses US spelling:
>
> /synchronised/synchronized/
>
> ~~~
>
> 2.
> +     Incremental sequence changes are not replicated.  Although the data in
> +     serial or identity columns backed by sequences will of course be
> +     replicated as part of the table, the sequences themselves do not replicate
> +     ongoing changes. On the subscriber, a sequence will retain the last value
>
> I didn't think that you needed to say "of course" here.

Thanks for the comments, the updated patch has the changes for the same.

Regards,
Vignesh