Re: Handle infinite recursion in logical replication setup

vignesh C <vignesh21@gmail.com>

From: vignesh C <vignesh21@gmail.com>

To: Amit Kapila <amit.kapila16@gmail.com>

Cc: "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>, Peter Smith <smithpb2250@gmail.com>, Dilip Kumar <dilipbalaut@gmail.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, "kuroda.hayato@fujitsu.com" <kuroda.hayato@fujitsu.com>, "shiy.fnst@fujitsu.com" <shiy.fnst@fujitsu.com>, "Jonathan S. Katz" <jkatz@postgresql.org>

Date: 2022-09-02T10:29:01Z

Lists: pgsql-hackers

Attachments

v45-0001-Check-and-log-a-warning-if-the-publisher-has-sub.patch (application/octet-stream) patch v45-0001
v45-0002-Document-the-steps-for-replication-between-prima.patch (application/octet-stream) patch v45-0002

On Mon, 29 Aug 2022 at 16:35, Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Wed, Aug 24, 2022 at 7:27 PM vignesh C <vignesh21@gmail.com> wrote:
> >
> > Since there was no objections to change it to throw a warning, I have
> > made the changes for the same.
> >
>
> Review comments for v42-0001*
> ==========================
> 1. Can we improve the query in check_pub_table_subscribed() so that it
> doesn't fetch any table that is already part of the subscription on
> the subscriber? This may be better than what the patch is doing which
> is to first fetch such information and then skip it. If forming this
> query turns out to be too complex then we can retain your method as
> well but I feel it is worth trying to optimize the query used in the
> patch.

I have modified the query to skip the tables as part of the query. The
attached v45 patch has the changes for the same.

Regards,
Vignesh

Commits

Improved CREATE SUBSCRIPTION message for clarity
- 1e7ca1189ccc 17.0 landed
- 842b65905046 16.0 landed
Fix the test case introduced by commit 8756930190.
- 032465157347 16.0 landed
Raise a warning if there is a possibility of data from multiple origins.
- 875693019053 16.0 landed
Add wait_for_subscription_sync for TAP tests.
- 0c20dd33db16 16.0 cited
Bump catversion for commit d8cd0c6c95c0120168df93aae095df4e0682a08a.
- 5f858dd3bebd 16.0 cited
Allow users to skip logical replication of data having origin.
- 366283961ac0 16.0 landed
Improve two comments related to a boolean DefElem's value
- 8445f5a21d40 16.0 cited
doc: Fix man page whitespace issues
- d7ab2a9a3c0a 15.0 cited