Horton

Re: Re[3]: On login trigger: take three

vignesh C <vignesh21@gmail.com>

View thread View on postgr.es
From: vignesh C <vignesh21@gmail.com>
To: Greg Nancarrow <gregn4422@gmail.com>
Cc: Ivan Panchenko <wao@mail.ru>, Pavel Stehule <pavel.stehule@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Amit Kapila <amit.kapila16@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>, Konstantin Knizhnik <k.knizhnik@postgrespro.ru>
Date: 2021-07-04T03:20:59Z
Lists: pgsql-hackers 
On Thu, Jun 3, 2021 at 8:36 AM Greg Nancarrow <gregn4422@gmail.com> wrote:
>
> On Fri, May 21, 2021 at 2:46 PM Greg Nancarrow <gregn4422@gmail.com> wrote:
> >
> > On Thu, May 20, 2021 at 2:45 PM Ivan Panchenko <wao@mail.ru> wrote:
> > >
> > > I have upgraded the patch for the 14th version.
> > >
> >
> > I have some feedback on the patch:
> >
>
> I've attached an updated version of the patch.
> I've applied my review comments and done a bit more tidying up of
> documentation and comments.
> Also, I found that the previously-posted patch was broken by
> snapshot-handling changes in commit 84f5c290 (with patch applied,
> resulting in a coredump during regression tests) so I've added a fix
> for that too.

CFBot shows the following failure:
# poll_query_until timed out executing this query:
# SELECT '0/3046250' <= replay_lsn AND state = 'streaming' FROM
pg_catalog.pg_stat_replication WHERE application_name = 'standby_1';
# expecting this output:
# t
# last actual query output:
# t
# with stderr:
# NOTICE: You are welcome!
# Looks like your test exited with 29 before it could output anything.
t/001_stream_rep.pl ..................
Dubious, test returned 29 (wstat 7424, 0x1d00)

Regards,
Vignesh

Commits

  1. Fix some typos in event trigger docs

  2. Use heap_inplace_update() to unset pg_database.dathasloginevt

  3. Remove the flaky check in event_trigger_login regression test

  4. Fix instable 006_login_trigger.pl test

  5. Add support event triggers on authenticated login

  6. Add GUC for temporarily disabling event triggers

  7. Fix typo in reference to __FreeBSD__.

  8. Restore robustness of TAP tests that wait for postmaster restart.

  9. Restore the portal-level snapshot after procedure COMMIT/ROLLBACK.