Re: Pgoutput not capturing the generated columns

vignesh C <vignesh21@gmail.com>

From: vignesh C <vignesh21@gmail.com>

To: Peter Smith <smithpb2250@gmail.com>

Cc: Amit Kapila <amit.kapila16@gmail.com>, Michael Paquier <michael@paquier.xyz>, "Shinoda, Noriyoshi (SXD Japan FSIP)" <noriyoshi.shinoda@hpe.com>, Shubham Khanna <khannashubham1197@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>, Rajendra Kumar Dangwal <dangwalrajendra888@gmail.com>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>, "euler@eulerto.com" <euler@eulerto.com>

Date: 2025-01-21T08:27:49Z

Lists: pgsql-hackers

Attachments

v54-0003-Fix-a-small-typo-in-publication-name.patch (text/x-patch) patch v54-0003
v54-0005-DOCS-Generated-Column-Replication.patch (text/x-patch) patch v54-0005
v54-0002-Add-missing-pubgencols-attribute-docs-for-pg_pub.patch (text/x-patch) patch v54-0002
v54-0001-Fix-incorrect-column-index-when-describing-publi.patch (text/x-patch) patch v54-0001
v54-0004-Change-publish_generated_columns-option-to-use-e.patch (text/x-patch) patch v54-0004

On Mon, 20 Jan 2025 at 06:14, Peter Smith <smithpb2250@gmail.com> wrote:
>
> Hi Vignesh,
>
> Review comments for patch v53-0001:
>
>
> Maybe I have some fundamental misunderstanding here, but I don't see
> why "this approach cannot be used with psql because older version
> servers may not have these columns". Not having the columns is the
> whole point of using an alias approach in the first place e.g. the
> below table t1 does not have a column called "banana" but it works
> just fine to select an alias using that name...

This is simpler than maintaining the indexes. I misunderstood your
comment to include displaying the columns for older versions, I did
not want to display a value for the older versions as these columns do
not exist. I have updated the patch based on the alias approach. The
attached patch has the changes for the same.

Regards,
Vignesh

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Doc: Generated column replication.
- 6252b1eaf82b 18.0 landed
Rename pubgencols_type to pubgencols in pg_publication.
- 75eb9766ec20 18.0 landed
Doc: Fix column name in pg_publication catalog.
- 117f9f328e0f 18.0 landed
Fix buildfarm failure introduced by commit e65dbc9927.
- b35434b134b1 18.0 landed
Change publication's publish_generated_columns option type to enum.
- e65dbc9927fb 18.0 landed
Fix \dRp+ output when describing publications with a lower server version.
- 991974bb4888 18.0 landed
Replicate generated columns when 'publish_generated_columns' is set.
- 7054186c4ebe 18.0 landed
Doc: Update the behavior of generated columns in Logical Replication.
- 5b0c46ea0932 18.0 landed
Replicate generated columns when specified in the column list.
- 745217a051a9 18.0 landed
Doc: Generated columns are skipped for logical replication.
- 7a089f6e6a14 17.0 cited