Horton

Re: Added schema level support for publication.

vignesh C <vignesh21@gmail.com>

View thread View on postgr.es
From: vignesh C <vignesh21@gmail.com>
To: Greg Nancarrow <gregn4422@gmail.com>
Cc: "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>, Rahila Syed <rahilasyed90@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Ajin Cherian <itsajin@gmail.com>, "tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>
Date: 2021-07-12T09:23:53Z
Lists: pgsql-hackers 
On Fri, Jul 9, 2021 at 12:12 PM Greg Nancarrow <gregn4422@gmail.com> wrote:
>
> On Fri, Jul 9, 2021 at 1:28 PM houzj.fnst@fujitsu.com
> <houzj.fnst@fujitsu.com> wrote:
> >
> > Currently, postgres caches publication actions info in the
> > RelationData::rd_pubactions, but after applying the patch, it seems
> > rd_pubactions is not initialized when using schema level publication.
> >
> > It cound result in some unexpected behaviour when checking if command
can be
> > executed with current replica identity.
> >
>
> While testing this patch, I'm finding that for a FOR SCHEMA
> publication, UPDATEs and DELETEs on tables belonging to that schema
> are not getting replicated (but INSERTs and TRUNCATEs are).
> Could this be related to the issues that Hou-san has identified?

Thanks for reporting this issue. I felt this issue is the same as the issue
which Hou San had reported. This issue is fixed in the v10 patch attached
at [1].
[1] -
https://www.postgresql.org/message-id/CALDaNm2%2BtR%2B8R-sD1CSyMbZcZbkintZE-avefjsp7LCkm6HMmw%40mail.gmail.com

Regards,
Vignesh

Commits

  1. Include schema/table publications even with exclude options in dump.

  2. Rename some enums to use TABLE instead of REL.

  3. Add tap tests for the schema publications.

  4. Allow publishing the tables of schema.

  5. In pg_dump, use simplehash.h to look up dumpable objects by OID.