Re: [PATCH] Initial progress reporting for COPY command

On Tue, Jun 23, 2020 at 4:45 PM Tomas Vondra
<tomas.vondra@2ndquadrant.com> wrote:
>
> >>
> >> Anyway if you would like to make this view more user-friendly, I can add that. Just ping me.
> >
> >I felt we could add pg_size_pretty to make the view more user friendly.
> >
>
> Please no. That'd make processing of the data (say, computing progress
> as processed/total) impossible. It's easy to add pg_size_pretty if you
> want it, it's impossible to undo it. I don't see a single pg_size_pretty
> call in system_views.sql.
>

I thought of including pg_size_pretty as we there was no total_bytes
to compare with, but I'm ok without it too as there is an option for
user to always include it in the client side like "SELECT
pg_size_pretty(file_bytes_processed) from pg_stat_progress_copy;" if
required.

Regards,
Vignesh
EnterpriseDB: http://www.enterprisedb.com