Re: Logical Replication of sequences

vignesh C <vignesh21@gmail.com>

From: vignesh C <vignesh21@gmail.com>

To: Peter Smith <smithpb2250@gmail.com>

Cc: shveta malik <shveta.malik@gmail.com>, Shlok Kyal <shlok.kyal.oss@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>, Peter Eisentraut <peter@eisentraut.org>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Tomas Vondra <tomas.vondra@enterprisedb.com>, Euler Taveira <euler@eulerto.com>, Michael Paquier <michael@paquier.xyz>, "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, Hou, Zhijie/侯志杰 <houzj.fnst@fujitsu.com>, "Jonathan S. Katz" <jkatz@postgresql.org>

Date: 2024-08-19T13:08:17Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Doc: Add documentation for sequence synchronization.
- 55cefadde874 19 (unreleased) landed
Remove unused assignment in CREATE PUBLICATION grammar.
- bfb7419b0bbe 19 (unreleased) landed
Add seq_sync_error_count to subscription statistics.
- f6a4c498dcf6 19 (unreleased) landed
Fix few issues in commit 5509055d69.
- 5a4eba558aa7 19 (unreleased) landed
Add sequence synchronization for logical replication.
- 5509055d6956 19 (unreleased) landed
Add worker type argument to logical replication worker functions.
- 3e8e05596a02 19 (unreleased) landed
Introduce "REFRESH SEQUENCES" for subscriptions.
- f0b3573c3aac 19 (unreleased) landed
Refactor logical worker synchronization code into a separate file.
- 41c674d2e31e 19 (unreleased) landed
Standardize use of REFRESH PUBLICATION in code and messages.
- 2436b8c047ff 19 (unreleased) landed
Add "ALL SEQUENCES" support to publications.
- 96b378497346 19 (unreleased) landed
Expose sequence page LSN via pg_get_sequence_data.
- b93172ca59f4 19 (unreleased) landed
Resume conflict-relevant data retention automatically.
- 0d48d393d465 19 (unreleased) cited
Post-commit review fixes for 228c370868.
- 1f7e9ba3ac4e 19 (unreleased) cited
Generate GUC tables from .dat file
- 63599896545c 19 (unreleased) cited

Attachments

v20240819-0001-Introduce-pg_sequence_state-function-for-e.patch (text/x-patch) patch v20240819-0001
v20240819-0004-Enhance-sequence-synchronization-during-su.patch (text/x-patch) patch v20240819-0004
v20240819-0003-Reorganize-tablesync-Code-and-Introduce-sy.patch (text/x-patch) patch v20240819-0003
v20240819-0002-Introduce-ALL-SEQUENCES-support-for-Postgr.patch (text/x-patch) patch v20240819-0002
v20240819-0005-Documentation-for-sequence-synchronization.patch (text/x-patch) patch v20240819-0005

On Mon, 19 Aug 2024 at 07:47, Peter Smith <smithpb2250@gmail.com> wrote:
>
> Here are my review comments for the latest patchset
>
> v20240817-0001. No changes. No comments.
> v20240817-0002. No changes. No comments.
> v20240817-0003. See below.
> v20240817-0004. See below.
> v20240817-0005. No changes. No comments.
>
> //////
>
> v20240817-0003 and 0004.
>
> (This is a repeat of the same comment as in previous reviews, but lots
> more functions seem affected now)
>
> IIUC, the LR code tries to follow function naming conventions (e.g.
> CamelCase/snake_case for exposed/static functions respectively),
> intended to make the code more readable. But, this only works if the
> conventions are followed.
>
> Now, patches 0003 and 0004 are shuffling more and more functions
> between modules while changing them from static to non-static (or vice
> versa). So, the function name conventions are being violated many
> times. IMO these functions ought to be renamed according to their new
> modifiers to avoid the confusion caused by ignoring the name
> conventions.

I have handled these in the v20240819 version patch attached.

Regards,
Vignesh