Re: [Proposal] Adding Log File Capability to pg_createsubscriber

vignesh C <vignesh21@gmail.com>

From: vignesh C <vignesh21@gmail.com>

To: Gyan Sreejith <gyan.sreejith@gmail.com>

Cc: Amit Kapila <amit.kapila16@gmail.com>, Euler Taveira <euler@eulerto.com>, "kuroda.hayato@fujitsu.com" <kuroda.hayato@fujitsu.com>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>, Peter Smith <smithpb2250@gmail.com>

Date: 2026-02-04T04:46:22Z

Lists: pgsql-hackers

On Mon, 2 Feb 2026 at 04:35, Gyan Sreejith <gyan.sreejith@gmail.com> wrote:
>
> Thank you!
>
> I have made the suggested changes.

You have missed to address the comments from [1]. Please change it as suggested.

[1] - https://www.postgresql.org/message-id/CALDaNm3Kx%3Dqv2XOf9x-bsOQx8R2aRBuJKxeTU0%2BSKR70G9WjZA%40mail.gmail.com

Regards,
Vignesh

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

pg_createsubscriber: Don't use MAXPGPATH
- 99b726ac4894 19 (unreleased) landed
pg_createsubscriber: Remove separate logfile_open() function
- f5528b90b411 19 (unreleased) landed
pg_createsubscriber: Use logging.c log file callback
- 847336ba53af 19 (unreleased) landed
Add log file support to logging.c
- 41237556f8c5 19 (unreleased) landed
pg_createsubscriber: Add -l/--logdir option to redirect output to files.
- 6b5b7eae3ae6 19 (unreleased) landed
pg_createsubscriber: Introduce module-specific logging functions.
- d6628a5ea0a5 19 (unreleased) landed
Fix another buglet in archive_waldump.c.
- 69c57466a752 19 (unreleased) cited