Re: Added schema level support for publication.
vignesh C <vignesh21@gmail.com>
From: vignesh C <vignesh21@gmail.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
Tom Lane <tgl@sss.pgh.pa.us>, Peter Smith <smithpb2250@gmail.com>,
"tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>, Greg Nancarrow <gregn4422@gmail.com>, Ajin Cherian <itsajin@gmail.com>, "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>,
Rahila Syed <rahilasyed90@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Date: 2021-09-08T05:18:23Z
Lists: pgsql-hackers
On Tue, Sep 7, 2021 at 5:10 PM Amit Kapila <amit.kapila16@gmail.com> wrote: > > On Tue, Sep 7, 2021 at 12:45 PM vignesh C <vignesh21@gmail.com> wrote: > > > > On Fri, Sep 3, 2021 at 4:49 PM Amit Kapila <amit.kapila16@gmail.com> wrote: > > > > > > > > 5. > > > If I modify the search path to remove public schema then I get the > > > below error message: > > > postgres=# Create publication mypub for all tables in schema current_schema; > > > ERROR: no schema has been selected > > > > > > I think this message is not very clear. How about changing to > > > something like "current_schema doesn't contain any valid schema"? This > > > message is used in more than one place, so let's keep it the same at > > > all the places if you agree to change it. > > > > I would prefer to use the existing messages as we have used this in a > > few other places similarly. Thoughts? > > > > Yeah, I also see the same message in code but I think here usage is a > bit different. If you see a similar SQL statement that causes the same > error message then can you please give an example? I was referring to the error message in create table postgres=# set search_path='non_existent_schema'; SET postgres=# create table t1(c1 int); ERROR: no schema has been selected to create in LINE 1: create table t1(c1 int); If it is not very useful in the case of creating a publication, then I can change it. Thoughts? Regards, Vignesh
Commits
-
Include schema/table publications even with exclude options in dump.
- 4aa6fa3cd0a2 18.0 landed
-
Rename some enums to use TABLE instead of REL.
- b3812d0b9bcf 15.0 landed
-
Add tap tests for the schema publications.
- 6b0f6f79eef2 15.0 landed
-
Allow publishing the tables of schema.
- 5a2832465fd8 15.0 landed
-
In pg_dump, use simplehash.h to look up dumpable objects by OID.
- 92316a4582a5 15.0 cited