Horton
Menu

Re: Pgoutput not capturing the generated columns

vignesh C <vignesh21@gmail.com>

View thread
From: vignesh C <vignesh21@gmail.com>
To: Peter Smith <smithpb2250@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>, Michael Paquier <michael@paquier.xyz>, "Shinoda, Noriyoshi (SXD Japan FSIP)" <noriyoshi.shinoda@hpe.com>, Shubham Khanna <khannashubham1197@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>, Rajendra Kumar Dangwal <dangwalrajendra888@gmail.com>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>, "euler@eulerto.com" <euler@eulerto.com>
Date: 2025-01-21T08:34:06Z
Lists: pgsql-hackers 
On Mon, 20 Jan 2025 at 08:59, Peter Smith <smithpb2250@gmail.com> wrote:
>
> IIUC, patch v53-0004 is primarily a bug fix for a docs omission of the
> master implementation.
>
> So,
>
> 1. IMO think this patch in its current form must come *before* the
> 0003 patch where you changed the PUBLICATION option from bool to enum.
>
> 2. Then the patch (currently called) 0003 needs to update this doc
> fragment to change the type from bool to char; it should also itemise
> the possible values 'n', 's' saying what those values mean.

These changes are done in the v54 version patch attached at [1].
Another thought was to remove this patch as it will get handled when
the "Change publish_generated_columns option to use enumChange
publish_generated_columns option to use enum" patch gets committed.
Also the comments form [2] and [3] are handled at [1].

[1] - https://www.postgresql.org/message-id/CALDaNm3zxQfJwYw7PwxtvYFAeCk6WkRt2iWu8HPWih8BubwU9g%40mail.gmail.com
[2] - https://www.postgresql.org/message-id/CAHut%2BPvuNx57RB%3DfUZv95q1Eb_01Lzv-%3DEnWDcDE%2BqFh7_yVag%40mail.gmail.com
[3] - https://www.postgresql.org/message-id/CAHut%2BPv9X9LjTJt0wU%2BySbZU-sXCO_bFmEGxinROkA48f8Ws%2Bw%40mail.gmail.com

Regards,
Vignesh

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Doc: Generated column replication.

  2. Rename pubgencols_type to pubgencols in pg_publication.

  3. Doc: Fix column name in pg_publication catalog.

  4. Fix buildfarm failure introduced by commit e65dbc9927.

  5. Change publication's publish_generated_columns option type to enum.

  6. Fix \dRp+ output when describing publications with a lower server version.

  7. Replicate generated columns when 'publish_generated_columns' is set.

  8. Doc: Update the behavior of generated columns in Logical Replication.

  9. Replicate generated columns when specified in the column list.

  10. Doc: Generated columns are skipped for logical replication.