Horton

Re: Logical Replication of sequences

vignesh C <vignesh21@gmail.com>

View thread
From: vignesh C <vignesh21@gmail.com>
To: Peter Smith <smithpb2250@gmail.com>
Cc: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, Masahiko Sawada <sawada.mshk@gmail.com>, shveta malik <shveta.malik@gmail.com>, Shlok Kyal <shlok.kyal.oss@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>, Peter Eisentraut <peter@eisentraut.org>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Euler Taveira <euler@eulerto.com>, Michael Paquier <michael@paquier.xyz>, "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>, "Jonathan S. Katz" <jkatz@postgresql.org>
Date: 2025-01-04T04:33:24Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Doc: Add documentation for sequence synchronization.

  2. Remove unused assignment in CREATE PUBLICATION grammar.

  3. Add seq_sync_error_count to subscription statistics.

  4. Fix few issues in commit 5509055d69.

  5. Add sequence synchronization for logical replication.

  6. Add worker type argument to logical replication worker functions.

  7. Introduce "REFRESH SEQUENCES" for subscriptions.

  8. Refactor logical worker synchronization code into a separate file.

  9. Standardize use of REFRESH PUBLICATION in code and messages.

  10. Add "ALL SEQUENCES" support to publications.

  11. Expose sequence page LSN via pg_get_sequence_data.

  12. Resume conflict-relevant data retention automatically.

  13. Post-commit review fixes for 228c370868.

  14. Generate GUC tables from .dat file

On Fri, 3 Jan 2025 at 09:07, Peter Smith <smithpb2250@gmail.com> wrote:
>
> Hi Vignesh,
>
> Some minor review comments for the patch v20241230-0003.
>
> ======
> src/backend/replication/logical/syncutils.c
>
> 1.
> + * syncutils.c
> + *   PostgreSQL logical replication: common synchronization code
> + *
> + * Copyright (c) 2024, PostgreSQL Global Development Group
>
> Happy New Year.
>
> s/2024/2025/

Modified

> ~~~
>
> 2.
> +/*
> + * Enum representing the overall state of subscription relations state.
> + *
> + * SYNC_RELATIONS_STATE_NEEDS_REBUILD indicates that the subscription relations
> + * state is no longer valid and the subscription relations should be rebuilt.
> + *
> + * SYNC_RELATIONS_STATE_REBUILD_STARTED indicates that the subscription
> + * relations state is being rebuilt.
> + *
> + * SYNC_RELATIONS_STATE_VALID indicates that subscription relation state is
> + * up-to-date and valid.
> + */
>
> 2a.
> That first sentence saying "overall state of [...] state" is a bit strange.
>
> Maybe it can be reworded something like:
> Enum for phases of the subscription relations state.

Modified

> ~
>
> 2b.
> /is no longer valid and/is no longer valid, and/

Modified

>
> 2c.
> /that subscription relation state is up-to-date/that the subscription
> relation state is up-to-date/

Modified

The changes for the same are available at the v20250204 version patch
attached at [1].

[1] - https://www.postgresql.org/message-id/CALDaNm07EtT7zQXhjvaX7AKUv_gKMsrSYxJQmmOHhpCZpvV07w%40mail.gmail.com

Regards,
Vignesh