Horton

Re: Added schema level support for publication.

vignesh C <vignesh21@gmail.com>

View thread View on postgr.es
From: vignesh C <vignesh21@gmail.com>
To: "tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>
Cc: Greg Nancarrow <gregn4422@gmail.com>, Ajin Cherian <itsajin@gmail.com>, "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>, Rahila Syed <rahilasyed90@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Date: 2021-08-03T15:08:28Z
Lists: pgsql-hackers

Attachments

On Tue, Aug 3, 2021 at 12:00 PM tanghy.fnst@fujitsu.com
<tanghy.fnst@fujitsu.com> wrote:
>
> On Monday, August 2, 2021 11:40 PM vignesh C <vignesh21@gmail.com>wrote:
> >
> > Thanks for the comments, attached v17 patches has the fixes for the same.
>
> Thanks for your new patch.
>
> I saw the following warning when compiling. It seems we don't need this variable any more.
>
> publicationcmds.c: In function ‘AlterPublicationSchemas’:
> publicationcmds.c:592:15: warning: unused variable ‘oldlc’ [-Wunused-variable]
>    ListCell   *oldlc;
>                ^~~~~

Thanks for reporting this, this is fixed in the v18 patch attached.

Regards,
Vignesh

Commits

  1. Include schema/table publications even with exclude options in dump.

  2. Rename some enums to use TABLE instead of REL.

  3. Add tap tests for the schema publications.

  4. Allow publishing the tables of schema.

  5. In pg_dump, use simplehash.h to look up dumpable objects by OID.