Horton

Re: Introduce XID age and inactive timeout based replication slot invalidation

vignesh C <vignesh21@gmail.com>

View thread
From: vignesh C <vignesh21@gmail.com>
To: Peter Smith <smithpb2250@gmail.com>
Cc: Nisha Moond <nisha.moond412@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>, "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, shveta malik <shveta.malik@gmail.com>, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>, Ajin Cherian <itsajin@gmail.com>, Bertrand Drouvot <bertranddrouvot.pg@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>, Nathan Bossart <nathandbossart@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-01-15T03:49:16Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Add a test for commit ac0e33136a using the injection point.

  2. Invalidate inactive replication slots.

  3. Fix incorrect slot type in BuildTupleHashTableExt

  4. Allow synced slots to have their inactive_since.

  5. Change last_inactive_time to inactive_since in pg_replication_slots.

  6. Track last_inactive_time in pg_replication_slots.

  7. Track invalidation_reason in pg_replication_slots.

  8. Add option force_initdb to PostgreSQL::Test::Cluster:init()

  9. Add a failover option to subscriptions.

  10. Allow setting failover property in the replication command.

  11. Allow to enable failover property for replication slots via SQL API.

  12. Track conflict_reason in pg_replication_slots.

  13. Log messages for replication slot acquisition and release.

  14. Remove vacuum_defer_cleanup_age

  15. Fix corruption due to vacuum_defer_cleanup_age underflowing 64bit xids

  16. meson: Add initial version of meson based build system

On Mon, 13 Jan 2025 at 12:48, Peter Smith <smithpb2250@gmail.com> wrote:
>
> On Mon, Jan 13, 2025 at 5:52 PM vignesh C <vignesh21@gmail.com> wrote:
> >
> > On Thu, 2 Jan 2025 at 15:57, Nisha Moond <nisha.moond412@gmail.com> wrote:
> > >
> > > On Thu, Jan 2, 2025 at 8:16 AM Peter Smith <smithpb2250@gmail.com> wrote:
> > > >
> > > > Hi Nisha,
> > > >
> > > > Here are some minor review comments for patch v58-0002.
> > > >
> ...
> >
> > 2) We can mention this as 1d  instead of 24h as we want to represent 1
> > day similar to how we have mentioned for log_rotation_age:
> > index a2ac7575ca..7284edfbc1 100644
> > --- a/src/backend/utils/misc/postgresql.conf.sample
> > +++ b/src/backend/utils/misc/postgresql.conf.sample
> > @@ -337,6 +337,7 @@
> >  #wal_sender_timeout = 60s      # in milliseconds; 0 disables
> >  #track_commit_timestamp = off  # collect timestamp of transaction commit
> >                                 # (change requires restart)
> > +#idle_replication_slot_timeout = 24h   # in minutes; 0 disables
> >
>
> Hi Vignesh. AFAIK that is due to a previous review comment of mine
> where I suggested we should use 24h format here, because this GUC
> default is described as "24 hours" in the config.sgml, and I felt the
> sample should match its own documentation.

I suggest we reverse the current approach: change the default
configuration value to 1d and update the documentation accordingly. I
preferred to set default values of 1h instead of 60 mins, 1d instead
of 24h, etc.

Regards,
Vignesh