Horton

Re: Enhance 'pg_createsubscriber' to retrieve databases automatically when no database is provided.

vignesh C <vignesh21@gmail.com>

View thread View on postgr.es
From: vignesh C <vignesh21@gmail.com>
To: Shubham Khanna <khannashubham1197@gmail.com>
Cc: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>, Nisha Moond <nisha.moond412@gmail.com>, Ajin Cherian <itsajin@gmail.com>, "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, Peter Smith <smithpb2250@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-03-20T10:11:01Z
Lists: pgsql-hackers 
On Thu, 20 Mar 2025 at 10:25, Shubham Khanna
<khannashubham1197@gmail.com> wrote:
>
>
> I have created two patches, v16-0001 and v16-0002, to address the
> performance issue. I conducted performance testing, and here are the
> results:
> - The difference in execution time between HEAD and the v15 patch was 53.2%.
> - After removing the suggested test cases, the difference reduced to
> 36.43%, showing a significant improvement.
>

It is still taking quite a while, can we compare with the following
too see how much extra time it takes:
a) remove insert and select verification for the all database
successful tests as all of these are logical replication verification
which is extensively tested b) remove command_fails_like failure tests
c) remove both of above and see.

Regards,
Vignesh

Commits

  1. Cosmetic fixes for pg_createsubscriber's -all option.

  2. pg_createsubscriber: Add '--all' option.