Re: Added schema level support for publication.

vignesh C <vignesh21@gmail.com>

From: vignesh C <vignesh21@gmail.com>

To: Amit Kapila <amit.kapila16@gmail.com>

Cc: Masahiko Sawada <sawada.mshk@gmail.com>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>, Tom Lane <tgl@sss.pgh.pa.us>, Peter Smith <smithpb2250@gmail.com>, "tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>, Greg Nancarrow <gregn4422@gmail.com>, Ajin Cherian <itsajin@gmail.com>, "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>, Rahila Syed <rahilasyed90@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>

Date: 2021-09-02T06:28:16Z

Lists: pgsql-hackers

Attachments

v24-0001-Made-the-existing-relation-cache-invalidation-an.patch (text/x-patch) patch v24-0001
v24-0002-Added-schema-level-support-for-publication.patch (text/x-patch) patch v24-0002
v24-0003-Tests-and-documentation-for-schema-level-support.patch (text/x-patch) patch v24-0003
v24-0004-Alter-publication-syntax-enhancement-to-keep-it-.patch (text/x-patch) patch v24-0004
v24-0005-Implemented-pg_publication_objects-view.patch (text/x-patch) patch v24-0005

On Tue, Aug 31, 2021 at 6:28 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> >
> > I have made these changes at the v23 patch attached at [1].
> >
>
> *
> +/*
> + * Invalidate the relations.
> + */
> +static inline void
> +InvalidatePublicationRels(List *relids)
>
> I don't see the need to make this an inline function.

Modified

> * On similar lines, the code in function
> GetPubPartitionOptionRelations seems to be extracted from existing
> function GetPublicationRelations(). Can't we move it into the 0001
> patch?

Modified

Thanks for the comments, the attached v24 patch has the changes for the same.

Regards,
Vignesh

Commits

Include schema/table publications even with exclude options in dump.
- 4aa6fa3cd0a2 18.0 landed
Rename some enums to use TABLE instead of REL.
- b3812d0b9bcf 15.0 landed
Add tap tests for the schema publications.
- 6b0f6f79eef2 15.0 landed
Allow publishing the tables of schema.
- 5a2832465fd8 15.0 landed
In pg_dump, use simplehash.h to look up dumpable objects by OID.
- 92316a4582a5 15.0 cited