Re: Added schema level support for publication.
vignesh C <vignesh21@gmail.com>
From: vignesh C <vignesh21@gmail.com>
To: Greg Nancarrow <gregn4422@gmail.com>
Cc: "tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>,
Ajin Cherian <itsajin@gmail.com>, Rahila Syed <rahilasyed90@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Date: 2021-07-21T17:34:42Z
Lists: pgsql-hackers
On Mon, Jul 19, 2021 at 2:41 PM Greg Nancarrow <gregn4422@gmail.com> wrote: > > On Fri, Jul 16, 2021 at 8:13 PM vignesh C <vignesh21@gmail.com> wrote: > > > > Modified. > > > > Thanks for the comments, these issues are fixed as part of the v12 patch posted at [1]. > > [1] - https://www.postgresql.org/message-id/CALDaNm3V9ny5dJM8nofLGJ3zDuDG0gS2dX%2BAhDph--U5y%2B4VbQ%40mail.gmail.com > > > > There seems to be a problem with ALTER PUBLICATION ... SET TABLE ... > After that command, it still regards it as an empty (e) publication, > so I can then ALTER PUBLICATION ... ADD SCHEMA ... > > e.g. > > test_pub=# create schema myschema; > CREATE SCHEMA > test_pub=# CREATE TABLE myschema.test (key int, value text, data jsonb); > CREATE TABLE > test_pub=# create publication pub1; > CREATE PUBLICATION > test_pub=# \dRp+ pub1 > Publication pub1 > Owner | All tables | Inserts | Updates | Deletes | Truncates | Via > root | Pubtype > -------+------------+---------+---------+---------+-----------+----------+--------- > gregn | f | t | t | t | t | f | e > (1 row) > > test_pub=# alter publication pub1 set table myschema.test; > ALTER PUBLICATION > test_pub=# \dRp+ pub1 > Publication pub1 > Owner | All tables | Inserts | Updates | Deletes | Truncates | Via > root | Pubtype > -------+------------+---------+---------+---------+-----------+----------+--------- > gregn | f | t | t | t | t | f | e > (1 row) > > test_pub=# alter publication pub1 add schema myschema; > ALTER PUBLICATION > test_pub=# \dRp+ pub1 > Publication pub1 > Owner | All tables | Inserts | Updates | Deletes | Truncates | Via > root | Pubtype > -------+------------+---------+---------+---------+-----------+----------+--------- > gregn | f | t | t | t | t | f | s > Schemas: > "myschema" Thanks for reporting this issue, this issue is fixed in the v13 patch posted at [1] [1] - https://www.postgresql.org/message-id/CALDaNm0%3DMaXyAok5iq_-DeWUd81vpdF47-MZbbrsd%2BzB2P6WwA%40mail.gmail.com Regards, Vignesh
Commits
-
Include schema/table publications even with exclude options in dump.
- 4aa6fa3cd0a2 18.0 landed
-
Rename some enums to use TABLE instead of REL.
- b3812d0b9bcf 15.0 landed
-
Add tap tests for the schema publications.
- 6b0f6f79eef2 15.0 landed
-
Allow publishing the tables of schema.
- 5a2832465fd8 15.0 landed
-
In pg_dump, use simplehash.h to look up dumpable objects by OID.
- 92316a4582a5 15.0 cited