Horton

Re: Added missing tab completion for alter subscription set option

vignesh C <vignesh21@gmail.com>

View thread View on postgr.es
From: vignesh C <vignesh21@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-06-14T02:50:40Z
Lists: pgsql-hackers 
On Fri, Jun 11, 2021 at 12:27 PM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Sun, May 23, 2021 at 04:24:59PM +0530, vignesh C wrote:
> >       /* Complete "CREATE SUBSCRIPTION <name> ...  WITH ( <opt>" */
> >       else if (HeadMatches("CREATE", "SUBSCRIPTION") && TailMatches("WITH", "("))
> > -             COMPLETE_WITH("copy_data", "connect", "create_slot", "enabled",
> > -                                       "slot_name", "synchronous_commit");
> > +             COMPLETE_WITH("binary", "copy_data", "connect", "create_slot",
> > +                                       "enabled", "slot_name", "streaming",
> > +                                       "synchronous_commit");
>
> "copy_data" and "connect" need to be reversed.  Applied.

Thanks for committing this.

Regards,
Vignesh

Commits

  1. Improve psql tab completion for options of subcriptions and publications