Horton

Re: Ordering of header file inclusion

vignesh C <vignesh21@gmail.com>

View thread
From: vignesh C <vignesh21@gmail.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Kuntal Ghosh <kuntalghosh.2007@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, Andres Freund <andres@anarazel.de>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2019-11-16T01:31:43Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Make the order of the header file includes consistent.

  2. Make the order of the header file includes consistent in backend modules.

  3. Make the order of the header file includes consistent in non-backend modules.

  4. Make the order of the header file includes consistent in contrib modules.

Attachments

On Tue, Nov 12, 2019 at 11:19 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Tue, Nov 12, 2019 at 6:33 AM vignesh C <vignesh21@gmail.com> wrote:
> >
> >
> > Thanks Amit for your comments. Please find the updated patch which
> > does not include the changes mentioned above.
> >
>
> Thanks for working on this.  I have pushed your latest patch.
>

Thanks Amit for pushing the patch. I have re-verified and found that
changes need  to be done in few more places. The main changes are made
in the header file and plpython source files. The attached patch
handles the same. I have verified make check and make check-world
including --with-python & --with-perl in the following:
CentOS Linux release 7.7.1908
Red Hat Enterprise Linux Server release 7.1

I have verified including --llvm in CentOS Linux release 7.7.1908.

Regards,
Vignesh
EnterpriseDB: http://www.enterprisedb.com