Re: enhance pg_log_backend_memory_contexts() to log memory contexts of auxiliary processes

vignesh C <vignesh21@gmail.com>

From: vignesh C <vignesh21@gmail.com>
To: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, torikoshia <torikoshia@oss.nttdata.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-11-29T02:44:19Z
Lists: pgsql-hackers
On Sun, Nov 28, 2021 at 7:15 PM Bharath Rupireddy
<bharath.rupireddyforpostgres@gmail.com> wrote:
>
> On Sun, Nov 28, 2021 at 5:21 PM vignesh C <vignesh21@gmail.com> wrote:
> > Thanks for the updated patch, one comment:
> > 1)  The function can be indented similar to other functions in the same file:
> > +CREATE FUNCTION memcxt_get_proc_pid(text)
> > +RETURNS int
> > +LANGUAGE SQL
> > +AS 'SELECT pid FROM pg_stat_activity WHERE backend_type = $1';
> >
> > Something like:
> > +CREATE FUNCTION memcxt_get_proc_pid(text)
> > +  RETURNS int
> > +  LANGUAGE SQL
> > +  AS 'SELECT pid FROM pg_stat_activity WHERE backend_type = $1';
>
> Done. PSA v6 patch.

Thanks for the updated patch. The patch applies neatly, make
check-world passes and the documentation looks good. I did not find
any issues with the v6 patch, I'm marking the patch as  Ready for
Committer.

Regards,
Vignesh



Commits

  1. Enhance pg_log_backend_memory_contexts() for auxiliary processes.