Horton

Re: locking [user] catalog tables vs 2pc vs logical rep

vignesh C <vignesh21@gmail.com>

View thread View on postgr.es
From: vignesh C <vignesh21@gmail.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: "osumi.takamichi@fujitsu.com" <osumi.takamichi@fujitsu.com>, Peter Smith <smithpb2250@gmail.com>, Andres Freund <andres@anarazel.de>, PostgreSQL-development <pgsql-hackers@postgresql.org>, Markus Wanner <markus.wanner@enterprisedb.com>
Date: 2021-06-17T01:41:35Z
Lists: pgsql-hackers 
On Wed, Jun 16, 2021 at 3:51 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Mon, Jun 14, 2021 at 5:33 PM osumi.takamichi@fujitsu.com
> <osumi.takamichi@fujitsu.com> wrote:
> >
> > On  Friday, June 11, 2021 2:13 PM  vignesh C <vignesh21@gmail.com> wrote:
> >
> > Attached the patch-set that addressed those two comments.
> >
>
> Few minor comments:
> 1.
> +      <listitem>
> +       <para>
> +        Clustering <structname>pg_class</structname> in a transaction.
>
> Can we change above to: Perform <command>CLUSTER</command> on
> <structname>pg_class</structname> in a transaction.
>
> 2.
> +      <listitem>
> +       <para>
> +        Executing <command>TRUNCATE</command> on user catalog table
> in a transaction.
> +       </para>
>
> Square brackets are missing for user.
>
> 3.
> +    <indexterm>
> +     <primary>Overview</primary>
> +    </indexterm>
> ..
> ..
> +    <indexterm>
> +     <primary>Caveats</primary>
> +    </indexterm>
>
> Why are these required when we already have titles? I have seen other
> places in the docs where we use titles for Overview and Caveats but
> they didn't have similar usage.
>

Even I felt this was not required. I had checked other places and also
prepared doc by removing it, it works fine.

Regards,
Vignesh

Commits

  1. Doc: Update caveats in synchronous logical replication.

  2. Document a few caveats in synchronous logical replication.

  3. Update the docs and comments for decoding of prepared xacts.

  4. Allow decoding at prepare time in ReorderBuffer.

  5. Documentation for logical decoding.