Horton

Re: Enhance 'pg_createsubscriber' to retrieve databases automatically when no database is provided.

vignesh C <vignesh21@gmail.com>

View thread View on postgr.es
From: vignesh C <vignesh21@gmail.com>
To: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
Cc: Shubham Khanna <khannashubham1197@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>, Peter Smith <smithpb2250@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Date: 2025-02-18T09:15:33Z
Lists: pgsql-hackers 
On Tue, 18 Feb 2025 at 06:22, Hayato Kuroda (Fujitsu)
<kuroda.hayato@fujitsu.com> wrote:
>
> I'm not sure we must really handle the case. Documentation [1] has already described
> not to run DDL commands during the command:
>
> ```
> Since DDL commands are not replicated by logical replication, avoid executing DDL
> commands that change the database schema while running pg_createsubscriber.
> If the target server has already been converted to logical replica, the DDL commands
> might not be replicated, which might cause an error.
> ```

Yes, that makes sense. Since the same applies to tables created while
pg_createsubscriber is running, and there is already generic
documentation covering this, I agree with you.

Regards,
Vignesh

Commits

  1. Cosmetic fixes for pg_createsubscriber's -all option.

  2. pg_createsubscriber: Add '--all' option.