Re: Inconsistency in reporting checkpointer stats
vignesh C <vignesh21@gmail.com>
From: vignesh C <vignesh21@gmail.com>
To: Nitin Jadhav <nitinjadhavpostgres@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, Robert Haas <robertmhaas@gmail.com>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2024-01-20T02:40:03Z
Lists: pgsql-hackers
On Sun, 19 Feb 2023 at 15:28, Nitin Jadhav <nitinjadhavpostgres@gmail.com> wrote: > > > This doesn't pass the tests, because the regression tests weren't adjusted: > > https://api.cirrus-ci.com/v1/artifact/task/5937624817336320/testrun/build/testrun/regress/regress/regression.diffs > > Thanks for sharing this. I have fixed this in the patch attached. > > > >> IMO, there's no need for 2 separate patches for these changes. > > I will make it a single patch while sharing the next patch. > > Clubbed both patches into one. The patch does not apply anymore, please post a rebased version of the patch : 1 out of 1 hunk FAILED -- saving rejects to file src/backend/catalog/system_views.sql.rej patching file src/backend/utils/activity/pgstat_checkpointer.c Hunk #1 FAILED at 52. 1 out of 1 hunk FAILED -- saving rejects to file src/backend/utils/activity/pgstat_checkpointer.c.rej patching file src/backend/utils/adt/pgstatfuncs.c Hunk #1 succeeded at 1217 with fuzz 1 (offset 24 lines). patching file src/include/access/xlog.h Hunk #1 succeeded at 165 (offset 3 lines). patching file src/include/catalog/pg_proc.dat Hunk #1 FAILED at 5680. 1 out of 1 hunk FAILED -- saving rejects to file src/include/catalog/pg_proc.dat.rej Regards, Vignesh
Commits
-
Fix inconsistent reporting of checkpointer stats.
- 17cc5f666f6a 18.0 landed
-
Defer flushing of SLRU files.
- dee663f78439 14.0 cited