Horton

Re: Fix publisher-side sequence permission reporting

vignesh C <vignesh21@gmail.com>

View thread View on postgr.es
From: vignesh C <vignesh21@gmail.com>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>, Tristan Partin <tristan@partin.io>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2026-06-29T16:01:14Z
Lists: pgsql-hackers 
On Fri, 26 Jun 2026 at 12:34, Fujii Masao <masao.fujii@gmail.com> wrote:
>
> On Wed, Jun 24, 2026 at 7:49 PM vignesh C <vignesh21@gmail.com> wrote:
> > Thanks for the patch. I verified that it fixes the issue with reading
> > unlogged sequences on a promoted standby.
>
> Thanks for testing!
>
>
> > Do you think it would be worthwhile to add a test for this scenario,
> > or do you feel the additional test is not necessary in this case?
>
> I think it's worth adding a test for this scenario, so I've added one to
> the patch. The test uses nextval() to read the unlogged sequence
> instead of pg_get_sequence_data(), since this patch needs to be
> backpatched to v15, while pg_get_sequence_data() was introduced in
> v19.

Thanks for the updated patches.  I verified that the issue occurs with
nextval() on all supported branches up to v15, where unlogged
sequences are available. The corresponding back patches apply cleanly
to their respective branches and fix the issue.  I also checked other
unlogged objects but couldn't reproduce a similar issue with them.

Overall, the patches look good to me.

Regards,
Vignesh

Commits

  1. Fix unlogged sequence corruption after standby promotion

  2. doc: Clarify pg_get_sequence_data() privileges and NULL results

  3. Fix misreporting of publisher sequence permissions during sync

  4. Introduce pg_sequence_read_tuple().