Re: Added schema level support for publication.

vignesh C <vignesh21@gmail.com>

From: vignesh C <vignesh21@gmail.com>

To: Amit Kapila <amit.kapila16@gmail.com>

Cc: Masahiko Sawada <sawada.mshk@gmail.com>, "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>, "tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>, Greg Nancarrow <gregn4422@gmail.com>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>, Tom Lane <tgl@sss.pgh.pa.us>, Peter Smith <smithpb2250@gmail.com>, Ajin Cherian <itsajin@gmail.com>, Rahila Syed <rahilasyed90@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>

Date: 2021-10-20T16:24:50Z

Lists: pgsql-hackers

Attachments

v44-0001-Allow-publishing-the-tables-of-schema.patch (text/x-patch) patch v44-0001
v44-0002-Add-client-side-support-to-logical-replication-f.patch (text/x-patch) patch v44-0002
v44-0003-Add-tests-for-the-schema-publication-feature-of-.patch (text/x-patch) patch v44-0003
v44-0004-Add-documentation-for-the-schema-publication-fea.patch (text/x-patch) patch v44-0004
v44-0005-Add-new-pg_publication_objects-view-to-display-T.patch (text/x-patch) patch v44-0005

On Wed, Oct 20, 2021 at 12:32 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Tue, Oct 19, 2021 at 9:42 PM vignesh C <vignesh21@gmail.com> wrote:
> >
>
> Thanks for the modified patch. I have a few more comments and suggestions:
>
> As the thread [1] is still not concluded, I suggest we fix the
> duplicate data case only when schemas are involved by slightly
> tweaking the code as per attached. This is just to give you an idea
> about what I have in mind, if you find a better solution then feel
> free to let me know.
>
> Few additional minor comments:
> 1.
> +-- Test the list of partitions published
>
> Shall we change the above comment as: "Test the list of partitions
> published with or without 'PUBLISH_VIA_PARTITION_ROOT' parameter"?

Modified

> 2. psql documentation for \dRp[+] needs to be modified.
>
> \dRp
> Before:
> " .. If + is appended to the command name, the tables associated with
> each publication are shown as well."
> After:
> " .. If + is appended to the command name, the tables and schemas
> associated with each publication are shown as well.

Modified

> Apart from the above, I think we should merge the first four patches
> as there doesn't seem to be any big problems pending. We can keep
> still keep tests added by 025_rep_changes_for_schema.pl as a separate
> patch as there might be some timing-dependent tests in that file.

This version of patch retains the changes related to
PublicationRelInfo, I will handle the merging of the patches in the
next version so that this version of patch change related to
PublicationRelInfo can be reviewed easily.

Attached v44 patch as the fixes for the same.

Regards,
Vignesh

Commits

Include schema/table publications even with exclude options in dump.
- 4aa6fa3cd0a2 18.0 landed
Rename some enums to use TABLE instead of REL.
- b3812d0b9bcf 15.0 landed
Add tap tests for the schema publications.
- 6b0f6f79eef2 15.0 landed
Allow publishing the tables of schema.
- 5a2832465fd8 15.0 landed
In pg_dump, use simplehash.h to look up dumpable objects by OID.
- 92316a4582a5 15.0 cited