Re: Race condition in FetchTableStates() breaks synchronization of subscription tables
vignesh C <vignesh21@gmail.com>
From: vignesh C <vignesh21@gmail.com>
To: Ajin Cherian <itsajin@gmail.com>
Cc: Alexander Lakhin <exclusion@gmail.com>,
"Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2024-03-13T03:48:48Z
Lists: pgsql-hackers
Attachments
- v6-0002-Apply-worker-will-get-started-after-180-seconds-b.patch (text/x-patch) patch v6-0002
- v6-0001-Table-sync-missed-for-newly-added-tables-because-.patch (text/x-patch) patch v6-0001
On Tue, 12 Mar 2024 at 09:34, Ajin Cherian <itsajin@gmail.com> wrote: > > > > On Tue, Mar 12, 2024 at 2:59 PM vignesh C <vignesh21@gmail.com> wrote: >> >> >> Thanks, I have created the following Commitfest entry for this: >> https://commitfest.postgresql.org/47/4816/ >> >> Regards, >> Vignesh > > > Thanks for the patch, I have verified that the fix works well by following the steps mentioned to reproduce the problem. > Reviewing the patch, it seems good and is well documented. Just one minor comment I had was probably to change the name of the variable table_states_valid to table_states_validity. The current name made sense when it was a bool, but now that it is a tri-state enum, it doesn't fit well. Thanks for reviewing the patch, the attached v6 patch has the changes for the same. Regards, Vignesh
Commits
-
Fix the missing table sync due to improper invalidation handling.
- a9155efc7004 16.3 landed
- aa79bde72565 17.0 landed
- 28a8cc457b02 15.7 landed