Horton

Re: Logical Replication of sequences

vignesh C <vignesh21@gmail.com>

View thread
From: vignesh C <vignesh21@gmail.com>
To: Peter Smith <smithpb2250@gmail.com>
Cc: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, Masahiko Sawada <sawada.mshk@gmail.com>, shveta malik <shveta.malik@gmail.com>, Shlok Kyal <shlok.kyal.oss@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>, Peter Eisentraut <peter@eisentraut.org>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Euler Taveira <euler@eulerto.com>, Michael Paquier <michael@paquier.xyz>, "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>, "Jonathan S. Katz" <jkatz@postgresql.org>
Date: 2025-05-03T13:57:36Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Doc: Add documentation for sequence synchronization.

  2. Remove unused assignment in CREATE PUBLICATION grammar.

  3. Add seq_sync_error_count to subscription statistics.

  4. Fix few issues in commit 5509055d69.

  5. Add sequence synchronization for logical replication.

  6. Add worker type argument to logical replication worker functions.

  7. Introduce "REFRESH SEQUENCES" for subscriptions.

  8. Refactor logical worker synchronization code into a separate file.

  9. Standardize use of REFRESH PUBLICATION in code and messages.

  10. Add "ALL SEQUENCES" support to publications.

  11. Expose sequence page LSN via pg_get_sequence_data.

  12. Resume conflict-relevant data retention automatically.

  13. Post-commit review fixes for 228c370868.

  14. Generate GUC tables from .dat file

Attachments

On Thu, 1 May 2025 at 08:46, vignesh C <vignesh21@gmail.com> wrote:
>
> On Tue, 29 Apr 2025 at 06:15, Peter Smith <smithpb2250@gmail.com> wrote:
> >
> > Hi Vignesh.
> >
> > Some trivial review comments for DOCS patch v20250428-0005.
> >
> > ======
> > doc/src/sgml/logical-replication.sgml
> >
> > 1.
> > +   Publications may currently only contain tables or sequences. Objects must be
> > +   added explicitly, except when a publication is created using
> > +   <literal>FOR TABLES IN SCHEMA</literal>, or <literal>FOR ALL
> > TABLES</literal>,
> > +   or <literal>FOR ALL SEQUENCES</literal>. Unlike tables, the current state of
> > +   sequences may be synchronised at any time. For more information, refer to
> > +   <xref linkend="logical-replication-sequences"/>.
> >    </para>
> >
> > AFAIK the PostgreSQL documentation uses US spelling:
> >
> > /synchronised/synchronized/
> >
> > ~~~
> >
> > 2.
> > +     Incremental sequence changes are not replicated.  Although the data in
> > +     serial or identity columns backed by sequences will of course be
> > +     replicated as part of the table, the sequences themselves do not replicate
> > +     ongoing changes. On the subscriber, a sequence will retain the last value
> >
> > I didn't think that you needed to say "of course" here.
>
> Thanks for the comments, the updated patch has the changes for the same.

There was one pending open comment #6 from [1]. This has been
addressed in the attached patch.
[1] - https://www.postgresql.org/message-id/OSCPR01MB14966DA8CB749A0D4E9F3F7A7F50E2%40OSCPR01MB14966.jpnprd01.prod.outlook.com

Regards,
Vignesh