Re: Allow logical replication to copy tables in binary format

vignesh C <vignesh21@gmail.com>

From: vignesh C <vignesh21@gmail.com>

To: Melih Mutlu <m.melihmutlu@gmail.com>

Cc: "Takamichi Osumi (Fujitsu)" <osumi.takamichi@fujitsu.com>, Peter Smith <smithpb2250@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>, "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, Dilip Kumar <dilipbalaut@gmail.com>, Euler Taveira <euler@eulerto.com>, pgsql-hackers <pgsql-hackers@postgresql.org>, "shiy.fnst@fujitsu.com" <shiy.fnst@fujitsu.com>

Date: 2023-03-15T15:12:18Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Allow logical replication to copy tables in binary format.
- ecb696527c01 16.0 landed
Common function for percent placeholder replacement
- c96de2ce1782 16.0 cited
Doc: add XML ID attributes to <sectN> and <varlistentry> tags.
- 78ee60ed84bb 16.0 cited
Re-order disable_on_error in tab-complete.
- d547f7cf5efc 16.0 cited
Make subscription tests pass with log_error_verbosity=verbose
- 19408aae7fa2 15.0 cited
Weaken type-OID-matching checks in array_recv and record_recv.
- 670c0a1d474b 14.0 cited
Allow logical replication to transfer data in binary format.
- 9de77b545313 14.0 cited

On Wed, 15 Mar 2023 at 15:30, Melih Mutlu <m.melihmutlu@gmail.com> wrote:
>
> Hi,
>
> Please see the attached patch.

One comment:
1) There might be a chance the result order of select may vary as
"ORDER BY" is not specified,  Should we add "ORDER BY" as the table
has multiple rows:
+# Check the synced data on the subscriber
+$result = $node_subscriber->safe_psql('postgres', 'SELECT a,b FROM
+public.test_col_order;');
+
+is( $result, '1|2
+3|4', 'check synced data on subscriber for different column order');

Regards,
Vignesh