Horton

Re: Ordering of header file inclusion

vignesh C <vignesh21@gmail.com>

View thread
From: vignesh C <vignesh21@gmail.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, Andres Freund <andres@anarazel.de>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2019-11-02T02:12:06Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Make the order of the header file includes consistent.

  2. Make the order of the header file includes consistent in backend modules.

  3. Make the order of the header file includes consistent in non-backend modules.

  4. Make the order of the header file includes consistent in contrib modules.

Attachments

On Fri, Oct 25, 2019 at 3:28 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Thu, Oct 24, 2019 at 2:43 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> >
> > On Wed, Oct 23, 2019 at 10:23 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
> > >
> > > Attached are patches for (a) and (b) after another round of review and
> > > fixes by Vignesh.   I am planning to commit the first one (a) tomorrow
> > > morning and then if everything is fine on buildfarm, I will commit the
> > > second one (b) and once both are good, I will look into the third one
> > > (c).   Another pair of eyes on these patches would be good.
> > >
> >
> > I have pushed the first one.  I'll wait for some time and probably
> > commit the second one tomorrow.
> >
>
> I have committed the second one as well.  Now, the remaining patch is
> for the entire backend.  I will pick it up after a few days.
>
Thanks Amit for committing the changes.
I found couple of more inconsistencies,  the attached patch includes
the fix for the same.

Regards,
Vignesh
EnterpriseDB: http://www.enterprisedb.com