Re: Enhanced error message to include hint messages for redundant options error

On Sat, May 1, 2021 at 9:02 PM Bharath Rupireddy
<bharath.rupireddyforpostgres@gmail.com> wrote:
>
> On Sat, May 1, 2021 at 7:25 PM vignesh C <vignesh21@gmail.com> wrote:
> > > > I'm not attaching above one line change as a patch, maybe Vignesh can
> > > > merge this into the main patch.
> >
> > Thanks for the comments. I have merged the change into the attached patch.
> > Thoughts?
>
> Thanks! v4 basically LGTM. Can we park this in the current commitfest
> if not done already?
>
> Upon looking at the number of places where we have the "option \"%s\"
> specified more than once" error, I, now strongly feel that we should
> use goto duplicate_error approach like in compute_common_attribute, so
> that we will have only one ereport(ERROR. We can change it in
> following files: copy.c, dbcommands.c, extension.c,
> compute_function_attributes, sequence.c, subscriptioncmds.c,
> typecmds.c, user.c, walsender.c, pgoutput.c. This will reduce the LOC
> greatly.
>
> Thoughts?

I have made the changes for this, I have posted the same in the v5
patch posted in my earlier mail.

Regards,
Vignesh