Horton

Thread

Commits

  1. Fix bogus tab-completion queries.

  1. Tab completion not listing schema list for create/alter publication for all tables in schema

    vignesh C <vignesh21@gmail.com> — 2022-03-13T17:03:43Z

    Hi,

I noticed that the following commands "CREATE PUBLICATION pub1 FOR ALL
TABLES IN SCHEMA" and  "ALTER PUBLICATION pub1 ADD ALL TABLES IN
SCHEMA" does not complete with the schema list. I feel this is because
of the following code in tab-complete.c:
.........
COMPLETE_WITH_QUERY_PLUS(Query_for_list_of_schemas
" AND nspname NOT LIKE E'pg\\\\_%'",
"CURRENT_SCHEMA");
.........
Here "pg\\\\_%" should be "pg\\\\_%%".
Attached a patch to handle this.
Thoughts?

Regards,
Vignesh

  2. Re: Tab completion not listing schema list for create/alter publication for all tables in schema

    Tom Lane <tgl@sss.pgh.pa.us> — 2022-03-13T23:53:36Z

    vignesh C <vignesh21@gmail.com> writes:
> Here "pg\\\\_%" should be "pg\\\\_%%".

Right you are.  Patch pushed, thanks!

			regards, tom lane

  3. Re: Tab completion not listing schema list for create/alter publication for all tables in schema

    vignesh C <vignesh21@gmail.com> — 2022-03-14T12:17:16Z

    On Mon, Mar 14, 2022 at 5:23 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> vignesh C <vignesh21@gmail.com> writes:
> > Here "pg\\\\_%" should be "pg\\\\_%%".
>
> Right you are.  Patch pushed, thanks!

Thanks for pushing the patch.

Regards,
Vignesh