Horton

Re: Include schema-qualified names in publication error messages.

vignesh C <vignesh21@gmail.com>

View thread
From: vignesh C <vignesh21@gmail.com>
To: Euler Taveira <euler@eulerto.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>, Dilip Kumar <dilipbalaut@gmail.com>, "shveta.malik@gmail.com" <shveta.malik@gmail.com>, Peter Smith <smithpb2250@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2026-05-08T05:53:50Z
Lists: pgsql-hackers

Attachments

On Thu, 7 May 2026 at 17:57, Euler Taveira <euler@eulerto.com> wrote:
>
> On Thu, May 7, 2026, at 3:00 AM, vignesh C wrote:
> >
> > * v5-0001-Include-schema-qualified-names-in-EXCEPT-clause-e.patch
> > * v5-0002-Include-schema-qualified-names-in-non-EXCEPT-publ.patch
>
> Regarding v5-0002:
>
>  check_publication_add_relation(PublicationRelInfo *pri)
>  {
>         Relation        targetrel = pri->relation;
> -       const char *relname;
>         const char *errormsg;
>
>         if (pri->except)
> -       {
> -               relname = get_relation_qualified_name(targetrel);
>                 errormsg = gettext_noop("cannot specify relation \"%s\" in the publication EXCEPT clause");
> -       }
>         else
> -       {
> -               relname = RelationGetRelationName(targetrel);
>                 errormsg = gettext_noop("cannot add relation \"%s\" to publication");
> -       }
>
> Why did you remove relname variable? In addition to reduce the patch size, you
> avoid increasing the number of modifications if the function
> get_relation_qualified_name is modified in the future.

I initially wanted to keep the changes aligned with the implementation
in HEAD. However, now that the patch has been committed, I agree with
retaining the variable. The attached patch includes the corresponding
changes.

Regards,
Vignesh