Re: Skipping schema changes in publication

On Wed, 18 Mar 2026 at 09:57, Peter Smith <smithpb2250@gmail.com> wrote:
>
> On Wed, Mar 18, 2026 at 3:10 PM shveta malik <shveta.malik@gmail.com> wrote:
> >
> > On Tue, Mar 17, 2026 at 9:21 PM vignesh C <vignesh21@gmail.com> wrote:
> > >
> > >
> > > These comments are addressed in the v65 version patch attached. Also
> > > the comments from [1] have been addressed in this.
> > > [1] - https://www.postgresql.org/message-id/CAA4eK1%2BmSpCzj%2BB2PW_68DJpXHA0KMgT9Nrz9P83_c1vdKya8g%40mail.gmail.com
> > >
> >
> > Thanks, few trivial things:
> >
> > 1)
> > In the doc we talk about the first two variants and then the third
> > variant. IIUC, you need to change variants to match the new details,
> > i.e.
> >
> > Change these:
> > ALTER PUBLICATION name ADD publication_object [, ...]
> > ALTER PUBLICATION name SET { publication_object [, ...] |
> > publication_all_object [, ... ] }
> > ALTER PUBLICATION name DROP publication_drop_object [, ...]
> >
> > to:
> > ALTER PUBLICATION name ADD publication_object [, ...]
> > ALTER PUBLICATION name DROP publication_drop_object [, ...]
> > ALTER PUBLICATION name SET { publication_object [, ...] |
> > publication_all_object [, ... ] }
> >
> > or change the details to match variants.
> >
>
> +1
>
> (I was about to post the same comment)
>
> Talking about "variants" like this forces the reader to keep referring
> back to the synopsis to try to figure out what is actually being
> described.
>
> A simple improvement like below could help clarify things:
> e.g. say "The third variant (DROP)" instead of just saying "The third variant"
> e.g. say "The fourth variant (SET parameters)" instead of just saying
> "The fourth variant"
> etc.
>
> Aside from that, AFAICT, the patch is a bit muddled about some variant numbers.
>
> e.g.1  "The first two variants modify which tables/schemas are part of
> the publication. The ADD and DROP clauses will add and remove one or
> more tables/schemas from the publication."
>
> No, because DROP is the 3rd variant, not in the "first two",
>
> e.g.2.  "The third variant either modifies the included tables/schemas
> or marks the publication..."
>
> No, the 3rd variant now is DROP. But this whole paragraph is referring
> to SET objects.

The order issue has been fixed in the v66 version patch attached at
[1]. I felt the variant related detailing improvement can be handled
separately if required after the patch is completed.
[1] - https://www.postgresql.org/message-id/CALDaNm1tKuU479T%3DwinBqoMb3MzO3Mta2juk8W3t2R5ps0_zyg%40mail.gmail.com

Regards,
Vignesh